mythic-insight/legendary-doc-site
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: Fix fragile tests that relied on semantic-ui classes

Browse source
This commit is contained in:
Robert Prehn 2020-09-08 15:01:15 -05:00
parent 97eabcc875
commit 3e1d8d3f3a
3 changed files with 4 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apps/app/priv/templates/phx.gen.html/form.html.eex
View file

@ -1,5 +1,5 @@
<%%= form_for @changeset, @action, [class: "ui large form"], fn f -> %> <%%= form_for @changeset, @action, [class: "ui large form"], fn f -> %>
<div class="ui stacked left aligned segment"> <div>
<%= for input <- Mix.Legendary.inputs(schema) do %> <%= for input <- Mix.Legendary.inputs(schema) do %>
<%= input %> <%= input %>
<% end %> <% end %>

10
apps/core/lib/core_web/views/helpers.ex
View file

@ -46,15 +46,9 @@ defmodule CoreWeb.Helpers do
""" """
end end
def styled_input(f, field, opts \\ [], options \\ nil) do def styled_input(f, field, opts \\ [], options \\ nil, block_list \\ []) do
styled_input(f, field, opts, options) do {content, _} = Keyword.pop(block_list, :do, "")
""
end
end
def styled_input(f, field, opts, options, do: content) do
{type, rest_opts} = Keyword.pop(opts, :type, input_type(f, field)) {type, rest_opts} = Keyword.pop(opts, :type, input_type(f, field))
IO.inspect(type)
{icon, rest_opts} = Keyword.pop(rest_opts, :icon, "") {icon, rest_opts} = Keyword.pop(rest_opts, :icon, "")
{classes, rest_opts} = Keyword.pop(rest_opts, :class, default_classes_for_type(type)) {classes, rest_opts} = Keyword.pop(rest_opts, :class, default_classes_for_type(type))
{label_text, rest_opts} = Keyword.pop(rest_opts, :label) {label_text, rest_opts} = Keyword.pop(rest_opts, :label)

6
apps/core/test/core_web/views/helpers_test.exs
View file

@ -74,13 +74,12 @@ defmodule CoreWeb.HelpersTest do
|> flash_block() |> flash_block()
|> safe_to_string() |> safe_to_string()
assert markup =~ "ui negative message" assert markup =~ "js-flash"
end end
test "styled_input/4 (without error)" do test "styled_input/4 (without error)" do
markup = safe_to_string(styled_input(form(), :no_error_field)) markup = safe_to_string(styled_input(form(), :no_error_field))
assert markup =~ ~S{<div class="field "}
assert markup =~ "<input" assert markup =~ "<input"
assert markup =~ "<label" assert markup =~ "<label"
end end
@ -88,10 +87,8 @@ defmodule CoreWeb.HelpersTest do
test "styled_input/4 (with error)" do test "styled_input/4 (with error)" do
markup = safe_to_string(styled_input(form(), :error_field)) markup = safe_to_string(styled_input(form(), :error_field))
assert markup =~ ~S{<div class="field error"}
assert markup =~ "<input" assert markup =~ "<input"
assert markup =~ "<label" assert markup =~ "<label"
assert markup =~ "ui pointing red basic label"
end end
test "styled_input/5 with content" do test "styled_input/5 with content" do
@ -104,7 +101,6 @@ defmodule CoreWeb.HelpersTest do
end end
|> safe_to_string() |> safe_to_string()
assert markup =~ ~S{<div class="field "}
assert markup =~ "<select" assert markup =~ "<select"
assert markup =~ "<label" assert markup =~ "<label"
end end