mythic-insight/calcom
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 5

Fix E2E Tests and Fix broken success page and non existing user URL (#2411)

Browse source
This commit is contained in:
Hariom Balhara 2022-04-07 13:04:19 +05:30 committed by GitHub
parent 652b15c9e7
commit 31a8f25bb6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apps/web/pages/[user]/[type].tsx
View file

@ -141,7 +141,7 @@ export const getServerSideProps = async (context: GetServerSidePropsContext) =>
}, },
}); });
if (!users) { if (!users || !users.length) {
return { return {
notFound: true, notFound: true,
}; };

6
apps/web/pages/success.tsx
View file

@ -487,10 +487,10 @@ export async function getServerSideProps(context: GetServerSidePropsContext) {
const profile = { const profile = {
name: eventType.team?.name || eventType.users[0]?.name || null, name: eventType.team?.name || eventType.users[0]?.name || null,
email: eventType.team ? null : eventType.users[0].email, email: eventType.team ? null : eventType.users[0].email || null,
theme: (!eventType.team?.name && eventType.users[0]?.theme) || null, theme: (!eventType.team?.name && eventType.users[0]?.theme) || null,
brandColor: eventType.team ? null : eventType.users[0].brandColor, brandColor: eventType.team ? null : eventType.users[0].brandColor || null,
darkBrandColor: eventType.team ? null : eventType.users[0].darkBrandColor, darkBrandColor: eventType.team ? null : eventType.users[0].darkBrandColor || null,
}; };
return { return {

1
apps/web/playwright/auth/delete-account.test.ts
View file

@ -1,6 +1,7 @@
import { expect, test } from "@playwright/test"; import { expect, test } from "@playwright/test";
test("Can delete user account", async ({ page }) => { test("Can delete user account", async ({ page }) => {
//FIXME: This test depends on seed.
// Login to account to delete // Login to account to delete
await page.goto(`/auth/login`); await page.goto(`/auth/login`);
// Click input[name="email"] // Click input[name="email"]

4
apps/web/playwright/booking-pages.test.ts
View file

@ -77,11 +77,11 @@ test.describe("pro user", () => {
test.use({ storageState: "playwright/artifacts/proStorageState.json" }); test.use({ storageState: "playwright/artifacts/proStorageState.json" });
test.beforeEach(async ({ page }) => { test.beforeEach(async ({ page }) => {
await deleteAllBookingsByEmail("pro@example.com");
await page.goto("/pro"); await page.goto("/pro");
}); });
test.afterAll(async () => { test.afterEach(async () => {
// delete test bookings
await deleteAllBookingsByEmail("pro@example.com"); await deleteAllBookingsByEmail("pro@example.com");
}); });

2
apps/web/playwright/dynamic-booking-pages.test.ts
View file

@ -12,6 +12,8 @@ test.describe("dynamic booking", () => {
test.use({ storageState: "playwright/artifacts/proStorageState.json" }); test.use({ storageState: "playwright/artifacts/proStorageState.json" });
test.beforeEach(async ({ page }) => { test.beforeEach(async ({ page }) => {
await deleteAllBookingsByEmail("pro@example.com");
await deleteAllBookingsByEmail("free@example.com");
await page.goto("/pro+free"); await page.goto("/pro+free");
}); });

4
apps/web/playwright/lib/testUtils.ts
View file

@ -72,7 +72,7 @@ export async function selectFirstAvailableTimeSlotNextMonth(page: Page) {
// @TODO: Find a better way to make test wait for full month change render to end // @TODO: Find a better way to make test wait for full month change render to end
// so it can click up on the right day, also when resolve remove other todos // so it can click up on the right day, also when resolve remove other todos
// Waiting for full month increment // Waiting for full month increment
await page.waitForTimeout(400); await page.waitForTimeout(1000);
// TODO: Find out why the first day is always booked on tests // TODO: Find out why the first day is always booked on tests
await page.locator('[data-testid="day"][data-disabled="false"]').nth(1).click(); await page.locator('[data-testid="day"][data-disabled="false"]').nth(1).click();
await page.click('[data-testid="time"]'); await page.click('[data-testid="time"]');
@ -83,7 +83,7 @@ export async function selectSecondAvailableTimeSlotNextMonth(page: Page) {
// @TODO: Find a better way to make test wait for full month change render to end // @TODO: Find a better way to make test wait for full month change render to end
// so it can click up on the right day, also when resolve remove other todos // so it can click up on the right day, also when resolve remove other todos
// Waiting for full month increment // Waiting for full month increment
await page.waitForTimeout(400); await page.waitForTimeout(1000);
// TODO: Find out why the first day is always booked on tests // TODO: Find out why the first day is always booked on tests
await page.locator('[data-testid="day"][data-disabled="false"]').nth(1).click(); await page.locator('[data-testid="day"][data-disabled="false"]').nth(1).click();
await page.locator('[data-testid="time"]').nth(1).click(); await page.locator('[data-testid="time"]').nth(1).click();

0
test Normal file
View file